Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention Jupyter in matplotlib usage #10781

Merged
merged 2 commits into from Mar 15, 2018
Merged

Mention Jupyter in matplotlib usage #10781

merged 2 commits into from Mar 15, 2018

Conversation

dniku
Copy link
Contributor

@dniku dniku commented Mar 14, 2018

PR Summary

Mention Jupyter in matplotlib usage.

No code is affected, text is reflown at 72 characters.

jklymak
jklymak approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. If you get another review and have to change anything, you could add a link to jupyter.org.

timhoffm
timhoffm approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can add the link. Otherwise, we'll merge it as is later on.

@dniku
Copy link
Contributor Author

dniku commented Mar 14, 2018 •
edited

Added a link. Hopefully I haven't broken reST formatting.

@jklymak
Copy link
Member

jklymak commented Mar 15, 2018

Link was good!

@jklymak jklymak merged commit 464df4a into matplotlib:master Mar 15, 2018
@dniku dniku deleted the patch-1 branch March 15, 2018 21:25
@QuLogic QuLogic added this to the v3.0 milestone Mar 16, 2018
@tacaswell tacaswell modified the milestones: v3.0, v2.2-doc Mar 16, 2018
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.2.0-doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2-doc
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dniku @jklymak @tacaswell @timhoffm @QuLogic